Interpret labels as UTF-8 in testFitStringInTextBox #22
Conversation
This fixes labels not showing up when certain characters, e.g. "à", were used in those labels. Signed-off-by: Timothy Pearson <[email protected]>
|
Would you be able to add a test case? |
|
I'm not entirely sure how this would be implemented as a test case. Is there a function that checks for the existence of rendered text on a graph? |
|
No, but I think there are tests that check the output of the bits that orient the items on the graph. Perhaps @kore can chime in on that? (And sorry for the late reply, I was on holiday) |
|
Ping @kore |
|
I tried to reproduce this on Linux by adding appropriate tests that compare image similarity but no avail, without /u it already works fine with all the examples given in #4 - I am inclined to just merge this. |
|
Merged (After rebase), so closing. |
|
We had to revert this as not all tests pass with this change, specifically when the text is not UTF-8 but ISO-8859-1, then using '/u' will fail. |
This fixes labels not showing up when certain characters,
e.g. "à", were used in those labels.
This fixes issue #4
Signed-off-by: Timothy Pearson [email protected]