ruby3.x-rails-8.0: new packages #39902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Paul <[email protected]>
Signed-off-by: Michael Paul <[email protected]>
Signed-off-by: Michael Paul <[email protected]>
imjasonh
previously approved these changes
Jan 17, 2025
jamonation
reviewed
Jan 17, 2025
ruby3.3-rails-8.0.yaml
Outdated
Comment on lines
12
to
15
| - gcc | ||
| - git | ||
| - glibc-dev | ||
| - make |
There was a problem hiding this comment.
These shouldn't be runtime depends should they?
There was a problem hiding this comment.
I commented them out locally just to triple-check and rebuilt it...I could've sworn it was failing without them earlier, but it works without them now so...I'll drop those off 🤷♂️
jamonation
reviewed
Jan 17, 2025
ruby3.3-rails-8.0.yaml
Outdated
| - glibc-dev | ||
| - make | ||
| - ruby${{vars.rubyMM}}-bundler | ||
| - ruby-${{vars.rubyMM}}-dev |
There was a problem hiding this comment.
Shouldn't be needed for runtime?
|
I think the runtime and build depends are mixed up here. Runtime shouldn't need much more than |
octo-sts
bot
added
the
bincapz/pass
Signed-off-by: Michael Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates Ruby on Rails package for Ruby 3.4, 3.3, and 3.2
Related: https://github.com/chainguard-dev/image-requests/issues/5160
EOL: https://endoflife.date/rails
Pre-review Checklist
For new package PRs only
endoflife.date)