Add grid-template-columns
to<CardGrid>
#2606
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a base
grid-template-columns
rule to the<CardGrid>
component to apply on smaller screens as one100%
wide column.This helps avoid overflow when there is complex content inside the grid children. We already apply this rule as an override in Astro Docs to avoid overflow, but I only just remembered to upstream this.
Why can this be an issue? Without an explicit column width, the grid uses an implicit width based on context. For example, without this rule, cards on the Astro Docs homepage would overflow due to the code block in the “Start a new project” card:
Adding an explicit column width avoids that and ensures children are constrained as expected: