feat: add support for server islands for MDX
#12446
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12252
Server Islands are not rendering as islands in .mdx files because server islands metadata is not added for JSX components in MDX files.
Even after adding server islands metadata, the issue persists because transform function in vite-plugin-server-islands.ts file runs before server metadata is added in rehype.ts file.
I found that vite-plugin-server-islands.ts is added last in create-vite.ts and has
enforce: 'post'but still transform function is running before the server meta data is added.I am looking for feedback and guidance from Astro contributors on how to fix it.
Testing
TODO
Docs
Not needed