Skip to content

Commit

Permalink
Update according review
Browse files Browse the repository at this point in the history
  • Loading branch information
youennf committed Jun 7, 2023
1 parent 4c80708 commit 9146111
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 18
- run: npm install
Expand Down
6 changes: 3 additions & 3 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -654,9 +654,8 @@ enum ReadableStreamType { "bytes", "owning" };
<p>Can be set to "<dfn enum-value for="ReadableStreamType">owning</dfn>" to signal that the
constructed {{ReadableStream}} will own chunks (via transfer or serialization) before enqueuing them.
This ensures that enqueued chunks are not mutable by the source.
Transferred or serialized chunks may have <dfn>dispose steps</dfn> which are executed if
enqueued chunks are dequeued without being provided to the application, for instance when
a {{ReadableStream}} is errored.
Chunks may have <dfn export>dispose steps</dfn> which are executed if enqueued chunks are dequeued
without being provided to the application, for instance when a {{ReadableStream}} is errored.
</p>

<p>Setting any value other than "{{ReadableStreamType/bytes}}", "{{ReadableStreamType/owning}}"
Expand Down Expand Up @@ -6779,6 +6778,7 @@ mark=] is greater than zero.

1. If |stream|.[=ReadableStream/[[controller]]=] [=implements=]
{{ReadableStreamDefaultController}},
1. If |transferList| is null, set |transferList| to an [=list/is empty|empty=] list.
1. Perform ! [$ReadableStreamDefaultControllerEnqueue$](|stream|.[=ReadableStream/[[controller]]=],
|chunk|, |transferList|).
1. Otherwise,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports.implementation = class ReadableStreamDefaultControllerImpl {
}

enqueue(chunk, options) {
const transferList = options ? options.transfer : [];
const transferList = options.transfer;
if (transferList.length && !this._isOwning) {
throw new TypeError('The stream is not an owning stream and cannot make use of options');
}
Expand Down

0 comments on commit 9146111

Please sign in to comment.