Make "inner invoke" use "remove an event listener" #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @oliverdunk! I saw your question on IRC about the participation agreement. The WHATWG Steering Group is trying to clarify this in whatwg/sg#67 and I'll ask them there about 1Password for you as it's not super clear to me. I'd assume not, but ... |
annevk
reviewed
May 7, 2019
dom.bs
Outdated
| <a for=list>remove</a> <var>listener</var> from <var>event</var>'s {{Event/currentTarget}} | ||
| attribute value's <a for=EventTarget>event listener list</a>. | ||
| <a>remove an event listener</a> with the <var>event</var>'s {{Event/currentTarget}} | ||
| and <var>listener</var></a>. | ||
| <!-- Do this before invocation to avoid reentrancy issues. No need to set removed to true since | ||
| each listener in listeners is run once anyway. --> |
There was a problem hiding this comment.
I'd reword the second sentence here to say something like "Note that there is no need to set removed to true since listener is run once, but it is done here to share an abstraction."
|
Thanks for the feedback @annevk! I'll try to update this soon, or at the very latest, when we're able to sort the legal situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR!
A small clarification where inner invoke now uses the "remove an event listener" definition, instead of doing this in its own way.
Resolves #651
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:33 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.