-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/port availability enhancements #5157
Open
Swapnilden
wants to merge
7
commits into
webpack:master
Choose a base branch
from
Swapnilden:feature/port-availability-enhancements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/port availability enhancements #5157
Swapnilden
wants to merge
7
commits into
webpack:master
from
Swapnilden:feature/port-availability-enhancements
Commits on Apr 11, 2024
-
Refactor webpack-dev-server middleware application logic
This commit refactors the middleware application logic in the webpack-dev-server codebase to ensure that middleware is applied only once, regardless of how many times it's called. Previously, certain middleware, such as static serving middleware, was being applied multiple times to support features like `historyApiFallback`. This refactor eliminates duplicate middleware application by introducing a mechanism to track applied middleware and applying each middleware only once. Changes: - Introduced `appliedMiddleware` array to track applied middleware. - Created `applyMiddlewareOnce` function to apply middleware only if it hasn't been applied before. - Updated webpack-dev-server codebase to utilize `applyMiddlewareOnce` for applying middleware associated with various features. This update aims to improve code efficiency and prevent unintended behavior or performance issues caused by duplicate middleware application. Fixes: webpack#2716
Configuration menu - View commit details
-
Copy full SHA for a39fb68 - Browse repository at this point
Copy the full SHA a39fb68View commit details -
In this updated version, I have included test cases to ensure that the applyMiddlewareOnce function behaves as expected. Additionally, I have removed references to contentBase, as requested.
Configuration menu - View commit details
-
Copy full SHA for 58bc6bd - Browse repository at this point
Copy the full SHA 58bc6bdView commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99e92e4 - Browse repository at this point
Copy the full SHA 99e92e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5b86f - Browse repository at this point
Copy the full SHA 1f5b86fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2efc25a - Browse repository at this point
Copy the full SHA 2efc25aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 645833d - Browse repository at this point
Copy the full SHA 645833dView commit details
Commits on Apr 20, 2024
-
These modifications ensure IPv6 support, improve error handling, and enhance code clarity.
Configuration menu - View commit details
-
Copy full SHA for bc317c4 - Browse repository at this point
Copy the full SHA bc317c4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.