Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor] Add experimental label to canary channel #1637

Closed
wants to merge 1 commit into from

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Nov 13, 2019

Fixes #1635

This must land right after web-platform-tests/wpt#20240 .

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won’t this cause both Dev and Canary to get the label, so that a random one of them ends up on the front page? Should we change the query of the front page to use concrete channel labels to not have to pretend Edge Dev is not experimental?

@Hexcles
Copy link
Member Author

Hexcles commented Nov 13, 2019

Yeah that's a great point that I didn't realize... Thanks, @foolip !

Short of a customizable homepage, I'd still prefer to show Edge Dev instead of Edge Canary by default for better alignment with Chrome. We should change the default query to accommodate this.

@foolip
Copy link
Member

foolip commented Nov 13, 2019

Approved so that it can be merged and released when the time is right.

Labeling both as experimental and changing the default query would solve most of the problem, but there may be people who have queries against the experimental label that they expect to be a consistent set of configurations. Not sure how to deal with that really.

@Hexcles
Copy link
Member Author

Hexcles commented Jul 28, 2020

Dropping this in favour of #2081

@Hexcles Hexcles closed this Jul 28, 2020
@Hexcles Hexcles deleted the edge-canary branch November 6, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Edge Canary have the 'experimental' label?
3 participants