Rename "prepare" script to "curate" to prevent auto-runs #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `prepare` script is run when the repository is installed. On top of creating issues when the repository is set as dependency in another project for some reason, as described in: #789 (comment) ... this also seems wrong because: 1. There is no guarantee that the curation will run without errors. A patch may no longer apply for instance. 2. Projects may want to depend on the raw data and may not need to run the curation and package preparation logic at all. This update replaces the "prepare" script with a "curate" one, explicitly called in the jobs that need it.
dontcallmedom
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
preparescript is run automatically when the repository is installed. On top of creating issues when the repository is set as dependency in another project for some reason, as described in #789 (comment), this also seems wrong because:npm install github:w3c/webrefmay fail from time to time.This update replaces the "prepare" script with a "curate" one, explicitly called by the jobs that need it.
I don't know if other projects depend on the
w3c/webrefrepository directly. If they do and need to access curated data, they would need to update to callnpm run curateexplicitly.