Clarify session.subscribe and session.unsubscribe
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| events: [*text], | ||
| ? contexts: [*browsingContext.BrowsingContext], | ||
| events: [+text], | ||
| ? contexts: [+browsingContext.BrowsingContext], |
There was a problem hiding this comment.
If we encounter events: [] or contexts: [] we should throw errors. Will add WPT tests for these cases.
There was a problem hiding this comment.
For session subscribe/unsubscribe, the update the event map algorithm is already making sure to skip duplicated events and contexts. It also has additional logic to deal with the fact that we only subscribe to top level context.
So I don't think we have to switch to sets to skip duplicates. Since it adds some complexity, maybe we should reconsider this?
Lightning00Blade
force-pushed
the
clarify-subscribe-sets
branch
from
2f5ba1a
to
025cc47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617.
Preview | Diff