Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested additional note for focus-not-obscured #4104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Oct 11, 2024

Closes #3529

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 98a3c0e
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6724f66a201a0b00095221ed
😎 Deploy Preview https://deploy-preview-4104--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -31,6 +31,8 @@ <h2>Intent of Focus Not Obscured (Minimum)</h2>

<p>Another form of obscuring can occur where light boxes or other semi-opaque effects overlap the item with focus. While less than 100 percent opacity is not causing the component to be <q>entirely obscured</q>, such semi-opaque overlaps may cause a failure of <a href="../understanding/non-text-contrast.html">1.4.11 Non-text Contrast</a>. When a focus indicator can be covered by a semi-opaque component, the ability of the focus indicator to pass 1.4.11 should be evaluated (and pass) while the focus indicator is under the semi-opaque component. The intention in both situations is that the component receiving focus should never be obscured to the point a user cannot tell which item has focus.</p>

<p class="note">The component does not include the focus indicator when considering "the component is not entirely hidden". Although both are needed by users when tracking the focus, it is a clearer metric to test when not including the indicator.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth introducing the clarification that the SC refers to the focused component, rather than the focus indication

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might also need further clarification about focus indicator that is around/outside of the component

Copy link
Member

@patrickhlauke patrickhlauke Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p class="note">The component does not include the focus indicator when considering "the component is not entirely hidden". Although both are needed by users when tracking the focus, it is a clearer metric to test when not including the indicator.</p>
<p class="note">This criterion evaluates the focused <em>component</em>, rather than the focus <em>indicator</em>. The component itself does not include the focus indicator when checking that "the component is not entirely hidden" - unless the focus indicator is inside the component, or focus is indicated by a change to the component itself. Although users benefit from both the component and the focus indicator (if external to the component) not being obscured when tracking the focus, for the purposes of this criterion only checking the component provides a clearer metric. However, if the focus indicator is obscured, it will already fail <a href="focus-visible">2.4.7 Focus Visible</a>.</p>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a suggested rewording, which introduces an explicit clarification that the SC is concerned with the component, rather than the indicator. also added cross-reference to 2.4.7 (check that the link works)

@alastc suggest that it would be good to have a similar note for the AAA

@patrickhlauke patrickhlauke self-assigned this Oct 18, 2024
@patrickhlauke
Copy link
Member

Please review my suggested tweak/addition above

@mbgower mbgower self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification for Understanding 2.4.11 Focus Not Obscured (Minimum) to ensure consistent testing
3 participants