Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-shapes-2] Specify the grammar for shape() #11207

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Nov 13, 2024

grammar changes:

  • <<position>> can be used instead of an absolute point
  • The relevant <<position>>'s dimension can be used for hline/vline
  • Since keywords define the different components, order of components is flexible
  • with is used for curve control points
  • Two curve control points are separated by /
  • Relative control points can be relative to segment-start/segment-end/reference-box, defaulting to segment start.

Resolution: #10649 (comment)

Closes #10649
Closes #10666

[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.

Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.

- <<position>> can be used instead of an absolute point.
- One of a <<position>>'s dimension can be used for hline/vline
- Since keywords define the different components, order of components is flexible.

Curves:
- `with` is used for control points
- Two control points are separated by /
- Relative control points can be relative to segment-start/segment-end/reference-box

Resolution: w3c#10649 (comment)

Closes w3c#10649
Closes w3c#10666
are relative to the top-left corner of the [=reference box=],
while ''by'' indicates that the <<coordinate-pair>>s
while <css>by</css> indicates that the <<coordinate-pair>>s
are relative to the command's starting point.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true when from start / from end are used. There probably needs to be a new paragraph that explains how control points are resolved, or a "see below for details".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... There is a paragraph for control points, I'll refer to that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use ''shape()/by'' for the markup. I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants