-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-gaps-1] Initial editor's draft. #10393 #11115
base: main
Are you sure you want to change the base?
Conversation
- Defer out gap decoration areas - Remove direction-relative properties - Flesh out definitions and algorithms - Add examples
Plus minor editorial changes.
I can't remember, was this based on feedback from the working group? |
Formatted version of draft can be found here: https://kbabbitt.github.io/css-gap-decorations/pr-11115/Overview.html |
It was based on feedback from the issue discussion.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, mostly just nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me, as well, with a few suggestions below.
@alisonmaher @KurtCattiSchmidt Thanks for the comments! I've pushed some changes with updates to the text; will work on making more visuals. |
Now updated with more visuals, and I've pushed an update to the formatted copy at https://kbabbitt.github.io/css-gap-decorations/pr-11115/Overview.html Ready for another look, thanks! edit: actually, missed one comment, will continue working on that. edit^2: last comment addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, thanks for adding all the visuals. This helped clarify all the questions I had.
The only other thoughts I had were if we should add an open issue for how to handle fragmentation and how to handle subgrid?
Otherwise, this looks good to me, thanks Kevin!
Major changes from the unofficial draft:
*-rule-break
to apply to all container typesjoin
keyword from*-rule-outset
and fold its behavior into*-rule-break