Update: account for common labeledby spelling variant for aria-labell… #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edby Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pkra
approved these changes
Nov 11, 2024
MelSumner
approved these changes
Nov 14, 2024
cookiecrook
reviewed
Nov 15, 2024
| @@ -11821,7 +11821,8 @@ <h2>Definitions of States and Properties (all aria-* attributes)</h2> | |||
| <p>If the interface is such that it is not possible to have a visible label on the screen, authors SHOULD use <pref>aria-label</pref> and SHOULD NOT use <pref>aria-labelledby</pref>. Authors MUST NOT specify <code>aria-labelledby</code> on an element which has an explicit or implicit WAI-ARIA role where <code>aria-labelledby</code> is <a href="#prohibitedattributes">prohibited</a>. As required by the <a href="#textalternativecomputation">accessible name and description computation</a>, user agents give precedence to <pref>aria-labelledby</pref> over <pref>aria-label</pref> when computing the accessible name property.</p> | |||
| <p>The <pref>aria-labelledby</pref> attribute is similar to <pref>aria-describedby</pref> in that both reference other elements to calculate a text alternative (an accessible name, and description, respectively). While a concise accessible name is preferable, a description can either be concise, or provide more verbose information.</p> | |||
| <!-- keep previous sentence synced with the associated description in #aria-describedby --> | |||
| <p class="note">The expected spelling of this property in <abbr title="United States">U.S.</abbr> English is "labeledby." However, the <a>accessibility <abbr title="Application Programing Interfaces">API</abbr></a> features to which this property is mapped have established the "labelledby" spelling. This property is spelled that way to match the convention and minimize the difficulty for developers.</p> | |||
| <p class="note">The expected spelling of this property in <abbr title="United States">U.S.</abbr> English is "labeledby." However, the <a>accessibility <abbr title="Application Programing Interfaces">API</abbr></a> features to which this property is mapped have established the "labelledby" spelling.</p> | |||
There was a problem hiding this comment.
Suggested change
| <p class="note">The expected spelling of this property in <abbr title="United States">U.S.</abbr> English is "labeledby." However, the <a>accessibility <abbr title="Application Programing Interfaces">API</abbr></a> features to which this property is mapped have established the "labelledby" spelling.</p> | |
| <p class="note">The expected spelling of this property in <abbr title="United States">U.S.</abbr> English is "labeled by." However, the <a>accessibility <abbr title="Application Programing Interfaces">API</abbr></a> feature this property was originally based on map had established the <abbr title="United Kingdom">U.K.</abbr> English spelling, "labelled by."</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing note and adds new ua and author requirements for instances of aria-labelledby and aria-labeledby
Closes #2093
i did not put this content into the accounting for author errors section, because it just fit a lot better in the aria-labelledby section. so if that's not the way we want to go about this update, then i'd appreciate help in rewording / moving the content to that section, as i was just not finding the words/logical placement for it there.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff