Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Remove important terms from CORE-AAM #2293

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Jul 25, 2024

There were only two important terms listed in CORE-AAM, and one of them had no references. The other was only used in one table, so I moved the definition to above the table.

https://deploy-preview-2293--wai-aria.netlify.app/core-aam

@spectranaut spectranaut added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:core-aam labels Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 80c7b87
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66c38e7521d8e80008e02e5b
😎 Deploy Preview https://deploy-preview-2293--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rahimabdi rahimabdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since one of the two definitions ("activation behavior") was removed because it was never referenced, I'm curious if it would be valuable to summarize/include it elsewhere such as section 4.8 Events.

Or alternatively, since "accessible object" now links to the ARIA spec, should the ARIA activation behavior definition be linked as well rather than entirely removing it?

core-aam/index.html Outdated Show resolved Hide resolved
@spectranaut
Copy link
Contributor Author

Thanks Rahim, for the thoughts/thoroughness! But there is no reference to anything like activation behavior in the events section, so from my perspective, there is no reason to include it. You got me curious about what that term was originally used for -- so I looked up the commit that added it: https://github.com/w3c/core-aam/pull/92/files

@jnurthen -- you added the term activation behavior.. but even when you added it, there was no reference to it in the spec. Do you know why? Is it ok to remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:core-aam
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants