Editorial: Add event definition for 'close' #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A reference to a 'close' event turned into a link back in d2bc4db but there wasn't a local definition - it ended up linking into HTML! This is now triggering a Bikeshed warning - yay! Add a minimal local definition for the event type, like the others.
|
@asutherland could you take a quick look? |
5 tasks
brettz9
reviewed
Jun 3, 2022
Co-authored-by: Brett Zamir <[email protected]>
|
Thanks @brettz9 ! |
marcoscaceres
approved these changes
Jun 8, 2022
|
The task source integration could be tightened up; there's just a generic declaration that everything happens using the database access task source. Firing of the event happens in close a database connection |
github-actions bot
added a commit
that referenced
this pull request
Jun 8, 2022
SHA: e196c63 Reason: push, by @inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference to a 'close' event turned into a link back in d2bc4db but
there wasn't a local definition - it ended up linking into HTML! This
is now triggering a Bikeshed warning - yay!
Add a minimal local definition for the event type, like the others.
(No normative behavior changes, no tests required.)
Preview | Diff