Introduce a specific criteria for selecting one of many candidate invalidating patches during extension. #238
+99
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garretrieger
force-pushed
the
selection
branch
from
0f195ed
to
d19123f
Compare
…alidating patches during extension. - For a set of patches who have the same intersection with the target subset definition and where that intersection is not a strict subset of any other intersections we know that exactly one of those patches will always be needed regardless of any other patch selections. - From there pick the one that has the smallest transfer size. - Here we use the ordering of a patch in the patch map as a signal for the relative transfer size of that patch. - Lastly, update encoding guidance to recommend encoders order map entries by transfer size ascending.
garretrieger
force-pushed
the
selection
branch
from
d19123f
to
bcf907b
Compare
skef
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Very good -- I was wondering if we should say more about the "an entry" in step 2, but I like the way you've handled the question in the Note. Given how we expect patches to be arranged the choice among the independent (same-intersection) patch groups would be basically arbitrary, as each one will have its own round trip. Suggesting loading the most StuffYouNeed first but not requiring that is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #235
Preview | Diff