fix(useIntersectionObserver): update syntax to handle stricter types #4333
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Before submitting the PR, please make sure you do the following
fixes #123
).Description
Due to stricter types planned on the upcoming v4 of Nuxt, the demo example needs to be updated.
You can look at this Nuxt issue for reference.
The Typescript issue occurs when
future: { compatibilityVersion: 4 },
is applied in thenuxt.config.ts
file.The change is not Nuxt related though, it concerns anyone.
It's simply applying an extra check on the
IntersectionObserverCallback
argument to ensure we handle the possibility of having anentry
beingundefined
instead of immediately de-structuring.Additional context
Reproduction link of the issue
As a bonus, it makes the code a bit more beginner-friendly (we could even use the name
entries
and access it viaentries[0]?.isIntersecting
but I think that's out-of-scope fromvueuse
, as all information are already available on MDN.I made a choice towards visibility but feel free to choose another way of writing it
For instance: (for brevity but less beginner-friendly)