Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scheduler-name field in charts #3766

Merged

Conversation

lengrongfu
Copy link
Contributor

add scheduler-name field in chart file to configuration custome scheduler name

From: #3748 (comment)

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2024
@lengrongfu
Copy link
Contributor Author

/cc @hwdef @Monokaix

@hwdef
Copy link
Member

hwdef commented Oct 11, 2024

Sorry I didn't express myself clearly,
What I mean is that parameters are added only when schedulerName is set by helm.
So, you code should like this

{{- if .Values.custom.common_labels }}

@lengrongfu
Copy link
Contributor Author

Sorry I didn't express myself clearly, What I mean is that parameters are added only when schedulerName is set by helm. So, you code should like this

{{- if .Values.custom.common_labels }}

Oh, then i know, thanks~

@lengrongfu lengrongfu force-pushed the feat/add-scheduler-name-to-charts branch from 2bb0c30 to 49a1916 Compare October 11, 2024 08:04
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@hwdef
Copy link
Member

hwdef commented Oct 11, 2024

The code can be optimized again.
You can add code like this,
In this way, there will be no changes in volcano-development.yaml when schedulerName is not set.

{{ $admission_ns := or .Values.custom.admission_ns .Values.custom.default_ns }}

@lengrongfu lengrongfu force-pushed the feat/add-scheduler-name-to-charts branch from 49a1916 to c94a4e1 Compare October 11, 2024 12:14
@hwdef
Copy link
Member

hwdef commented Oct 12, 2024

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
@Monokaix
Copy link
Member

The webhook modification will be done at your another pr?

@lengrongfu
Copy link
Contributor Author

The webhook modification will be done at your another pr?

I think so, try to keep the functional independence of each PR.

@Monokaix
Copy link
Member

/ok-to-test
/approve

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 16, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@volcano-sh-bot volcano-sh-bot merged commit 8d05ea0 into volcano-sh:master Oct 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants