Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3196: Update vision docs for camera interface update #4717

Merged
merged 4 commits into from
Jan 17, 2025
Merged

DOCS-3196: Update vision docs for camera interface update #4717

merged 4 commits into from
Jan 17, 2025

Conversation

sguequierre
Copy link
Contributor

  • use DecodeImageFromCamera instead of Stream/Next

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision GetProperties

npentrel
npentrel reviewed Jan 16, 2025
View reviewed changes
services/vision/vision.go Outdated
// img, release, err := camStream.Next(context.Background())
// defer release()
// // Get an image from the camera decoded as an image.Image
// img, err = camera.DecodeImageFromCamera(context.Background(), utils.MimeTypeJPEG, nil, myCam)
Copy link
Contributor

@npentrel npentrel Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are utils included by default or do we need to add that the user needs to import this?

npentrel
npentrel approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you have run this code and it works.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 16, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 16, 2025
@sguequierre sguequierre merged commit 4f2b707 into main Jan 17, 2025
16 checks passed
@sguequierre sguequierre deleted the DOCS-3196/get-image-changes branch January 17, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npentrel npentrel npentrel approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sguequierre @npentrel @viambot