Merge pull request #201 from blenderskool/fix-models-type-issues

Fix incorrect type issues in conversation models methods
typesense · Apr 24, 2024 · 36dd89f · 36dd89f
2 parents 678a55e + 491b3b1
commit 36dd89f
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 15 deletions.
diff --git a/dist/typesense.js.map b/dist/typesense.js.map
diff --git a/dist/typesense.min.js.map b/dist/typesense.min.js.map
diff --git a/lib/Typesense/ConversationModels.d.ts b/lib/Typesense/ConversationModels.d.ts
@@ -1,13 +1,10 @@
 import ApiCall from "./ApiCall";
 import { ConversationModelCreateSchema, ConversationModelSchema } from "./ConversationModel";
-export interface ConversationModelsRetrieveSchema {
-    models: ConversationModelSchema[];
-}
 export default class ConversationModels {
     private readonly apiCall;
     constructor(apiCall: ApiCall);
     create(params: ConversationModelCreateSchema): Promise<ConversationModelCreateSchema>;
-    retrieve(): Promise<ConversationModelsRetrieveSchema>;
+    retrieve(): Promise<ConversationModelSchema[]>;
     private endpointPath;
     static get RESOURCEPATH(): string;
 }
diff --git a/lib/Typesense/ConversationModels.js.map b/lib/Typesense/ConversationModels.js.map
diff --git a/lib/Typesense/Conversations.d.ts b/lib/Typesense/Conversations.d.ts
@@ -11,6 +11,7 @@ export default class Conversations {
     private readonly individualConversationModels;
     constructor(apiCall: ApiCall);
     retrieve(): Promise<ConversationsRetrieveSchema>;
-    models(id?: string): ConversationModels | ConversationModel;
+    models(): ConversationModels;
+    models(id: string): ConversationModel;
     static get RESOURCEPATH(): string;
 }
diff --git a/lib/Typesense/Conversations.js.map b/lib/Typesense/Conversations.js.map
diff --git a/src/Typesense/ConversationModels.ts b/src/Typesense/ConversationModels.ts
@@ -4,10 +4,6 @@ import {
   ConversationModelSchema,
 } from "./ConversationModel";
 
-export interface ConversationModelsRetrieveSchema {
-  models: ConversationModelSchema[];
-}
-
 const RESOURCEPATH = "/conversations/models";
 
 export default class ConversationModels {
@@ -24,8 +20,8 @@ export default class ConversationModels {
     );
   }
 
-  async retrieve(): Promise<ConversationModelsRetrieveSchema> {
-    return this.apiCall.get<ConversationModelsRetrieveSchema>(
+  async retrieve(): Promise<ConversationModelSchema[]> {
+    return this.apiCall.get<ConversationModelSchema[]>(
       this.endpointPath(),
     );
   }

diff --git a/src/Typesense/Conversations.ts b/src/Typesense/Conversations.ts
@@ -25,6 +25,8 @@ export default class Conversations {
     return this.apiCall.get<ConversationsRetrieveSchema>(RESOURCEPATH);
   }
 
+  models(): ConversationModels;
+  models(id: string): ConversationModel;
   models(id?: string): ConversationModels | ConversationModel {
     if (id === undefined) {
       return this._conversationsModels;