Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR introduces a new
SearchHighlightV2
type which is used for theSearchResultHit#highlight
field.I've opened this as a draft as this version of the spec doesn't quite play nicely with the generator used by
typesense-go
(it creates some weirdly named structs). The generated Go version can be a bit nicer by making these changes:Annoyingly, the Go version still doesn't offer a way to detect if the
oneOf
is an array or not, instead throwing an error if you call the wrongAsSearchHighlightV2*
function.But introducing an additional schema seems less than ideal. I'm open to any suggestions on how to improve this further.
PR Checklist