Move span creation to middleware #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msosnicki
force-pushed
the
create-span-server-middleware
branch
from
a80c6a9
to
e0d03cd
Compare
|
👍 for this, we've been having to write little wrapper middlewares to do the parent span options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to change the behavior of
NatchezMiddleware.server.Currently, it puts the context into existing span. The span per request is created in the
EntryPointOps, which is only used forKleislibased implementation. It means that server middleware is not working correctly withIOLocalbased tracing.The proposal is to move the span creation (+ continuation) into middleware itself, and inject
RootsSpanforKleislibased routes.If it's accepted, I can drop in few tests that verify that both
IOLocalandKleisliTrace implementations yield the same results.