-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing for async route methods #614
Open
wsanchez
wants to merge
3
commits into
trunk
Choose a base branch
from
typing-renderable
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> KleinRenderable
isn't doing what you think here, becauseKleinRenderable
includes bothKleinSynchronousRenderable
andAwaitable[KleinSynchronousRenderable]
, and you can't return both of those here; due to the implicit modification ofasync def
, the actual return type of this function becomes (handwaving a bit over theCoroutine
junk)Awaitable[Union[KleinSynchronousRenderable, Awaitable[KleinSynchronousRenderable]]
, which is gibberish.What you actually want to do with these methods is to say, for example, "
-> str
", which will implicitly match against-> KleinRenderable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK that works for cases where I know the specific type I'm returning. What if I'm returning the result of something that gives me a
KleinRenderable
?Presumably I will have awaited on it if appropriate, so I agree that maybe this should be
KleinSynchronousRenderable
, though that's currently not public.That is, it should be possible to type this generically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I use
KleinSynchronousRenderable
, I at least get passing for these, but it doesn't catchasyncReturnsObject
as invalid… so not perfect, but better.