Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch for 24.10.0 release #45

Merged
merged 5 commits into from
Oct 22, 2024
Merged

branch for 24.10.0 release #45

merged 5 commits into from
Oct 22, 2024

Conversation

glyph
Copy link
Member

@glyph glyph commented Oct 16, 2024

No description provided.

@glyph
Copy link
Member Author

glyph commented Oct 16, 2024

Hey @rouge8 this includes your changes, and is live as a release candidate on https://pypi.org/project/ampoule/ since there hasn't been a release in a while. I think I might want to update the trove classifiers here to be more accurate before doing a final, but I just wanted to make sure we don't have any hiccups in the release process that would cause issues for you.

@rouge8
Copy link
Contributor

rouge8 commented Oct 16, 2024

@glyph I don't think this has #43 and #41 in it -- I still get the warnings and https://github.com/twisted/ampoule/commits/release-24.10 only shows #42. I opened #46 with all the packaging cleanup I could think of.

@glyph
Copy link
Member Author

glyph commented Oct 16, 2024

sigh, indeed it does not. let's try that again

@glyph
Copy link
Member Author

glyph commented Oct 16, 2024

OK, rc2 is uploaded.

Copy link
Contributor

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this passes our CI and some manual testing i did

@glyph
Copy link
Member Author

glyph commented Oct 16, 2024

Thanks for confirming!

@rouge8
Copy link
Contributor

rouge8 commented Oct 17, 2024

@glyph is there anything else I can help with for a final release?

@glyph glyph merged commit 58d3003 into master Oct 22, 2024
7 checks passed
@glyph glyph deleted the release-24.10 branch October 22, 2024 04:31
@glyph
Copy link
Member Author

glyph commented Oct 22, 2024

@glyph is there anything else I can help with for a final release?

I was just sick again and then busy again, so blocked for a little while, but all done now. Thanks for the prompt!

@glyph
Copy link
Member Author

glyph commented Oct 22, 2024

(And, now that there are no open branches, another master bites the dust, and we are on the Twisted standard of trunk for the main branch.)

@rouge8
Copy link
Contributor

rouge8 commented Oct 22, 2024

@glyph is there anything else I can help with for a final release?

I was just sick again and then busy again, so blocked for a little while, but all done now. Thanks for the prompt!

Glad you’re feeling better! Thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants