Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] chore: updating aws access configuration #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] chore: updating aws access configuration #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/apt-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ jobs:
steps:
- name: Check Out Repo
uses: actions/checkout@v2

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
role-to-assume: ${{ secrets.AWS_ACCESS_ROLE}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the maintenance for this role? Would we have to rotate/re-generate it periodically?

aws-region: us-east-1

- name: generate linux tarball
Expand All @@ -29,7 +27,7 @@ jobs:
GPG_SIGNING_KEY: ${{ secrets.GPG_SIGNING_KEY}}
GPG_SIGNING_KEY_ID: ${{ secrets.GPG_SIGNING_KEY_ID }}
GPG_SIGNING_KEY_PASSPHRASE: ${{ secrets.GPG_SIGNING_KEY_PASSPHRASE }}
run: |
run: |
node .github/scripts/pack-debian-apt.js x64,arm

notify-complete-fail:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/oclif-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ jobs:
- name: Configure AWS credentials from Test account
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
role-to-assume: ${{ secrets.AWS_ACCESS_ROLE}}
aws-region: us-east-1
- name: Publish assests to s3 and calculate sha of oclif dev pack
id: sha256
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/release-token-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ jobs:
token-validation:
runs-on: ubuntu-latest
steps:
- name: Validate REPO_ACCESS_TOKEN
- name: Validate REPO_ACCESS_TOKEN
uses: actions/checkout@v2
with:
repository: '${{ github.repository_owner }}/twilio-oai'
token: ${{ secrets.REPO_ACCESS_TOKEN }}
- name: Validate AWS tokens
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
aws-region: us-east-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the workflow log, it seems the default region is set to 'ap-south-1'. Dont think its expected?

role-to-assume: ${{ secrets.AWS_ACCESS_ROLE}}
aws-region: us-east-1