Use statistics in Faker CTAS #24585
Open
Use statistics in Faker CTAS #24585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raunaqmorarka this is the last one, I promise :-) |
nineinchnick
commented
Dec 26, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
nineinchnick
commented
Dec 27, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 28, 2024
nineinchnick
force-pushed
the
faker-range-constraint-views
branch
3 times, most recently
from
8af4d29 to
c40b9fa
Compare
|
@raunaqmorarka and @losipiuk this is ready for a review. It's the last one about Faker, I don't have anything else planned for it. |
|
@raunaqmorarka @losipiuk a gentle reminder |
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
Comment on lines
+506
to
+507
| properties.put(ALLOWED_VALUES_PROPERTY, columnValues.get(column.name()).stream() | ||
| .map(value -> Literal.format(column.type(), value)) | ||
| .collect(toImmutableList())); |
There was a problem hiding this comment.
I don't know, but the max number of values is configurable, with a reasonable default of 1000. This might throw a some exception for big values, but I don't think we have to prevent that.
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 17, 2025
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerConnector.java
Show resolved
Hide resolved
losipiuk
approved these changes
Jan 17, 2025
When creating a table in the Faker connector from an existing table, gather column statistics to determine range constraints, set them as column properties.
When creating a table in the Faker connector from an existing table, using column statistics determine low cardinality columns, and generate values from a randomly generated set.
nineinchnick
force-pushed
the
faker-range-constraint-views
branch
from
c40b9fa to
c2f5400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use statistics when using
CREATE TABLE AS SELECTin the Faker connector to:default_limittable property to the estimated number of rows from the source tableminandmaxcolumn properties based on the statisticsAdditional context and related issues
Previous attempt #24098 was abandoned after #24147 was reported. This time we only use views for sequence columns, and if this is not very useful, we can avoid creating the views automatically. Or this could be yet another column property.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: