Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Export prepareMethod #5439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Nov 15, 2024

CNCT-2381


PR-Codex overview

This PR adds a new export to the contract.ts file, enhancing the available utilities for contract interactions.

Detailed summary

  • Added export for prepareMethod from ../utils/abi/prepare-method.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl added the Enhancement An improvement on existing functionality with no modifications to the public API. label Nov 15, 2024
@gregfromstl gregfromstl self-assigned this Nov 15, 2024
Copy link

linear bot commented Nov 15, 2024

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 10:11am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 10:11am
thirdweb-www ❌ Failed (Inspect) Nov 16, 2024 10:11am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 10:11am

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 7b7be4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.88 KB (0%) 898 ms (0%) 482 ms (+6.79% 🔺) 1.4 s
thirdweb (cjs) 105.07 KB (0%) 2.2 s (0%) 603 ms (+5.41% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 106 ms (+560.46% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-49.34% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 42 ms (-22.15% 🔽) 418 ms

Copy link
Member Author

gregfromstl commented Nov 15, 2024

Merge activity

  • Nov 15, 6:37 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 16, 4:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 16, 5:11 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www').

CNCT-2381

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds a new export to the `contract.ts` file, enhancing the functionality related to method preparation.

### Detailed summary
- Added export of `prepareMethod` from `../utils/abi/prepare-method.js` to `packages/thirdweb/src/exports/contract.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.49%. Comparing base (a00233d) to head (7b7be4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5439      +/-   ##
==========================================
- Coverage   45.53%   45.49%   -0.04%     
==========================================
  Files        1070     1071       +1     
  Lines       55690    55718      +28     
  Branches     4033     4031       -2     
==========================================
- Hits        25356    25351       -5     
- Misses      29647    29680      +33     
  Partials      687      687              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a00233d
packages 40.60% <ø> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An improvement on existing functionality with no modifications to the public API. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants