Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: Integrate billing v2 init #5432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 15, 2024

PR-Codex overview

This PR primarily focuses on refactoring and updating the billing-related components and logic within the application. It introduces new billing plans, modifies existing components for better usability, and enhances the onboarding process.

Detailed summary

  • Deleted unused files related to onboarding and billing.
  • Updated TrackedLinkButtonProps and related interfaces.
  • Renamed LazyOnboardingBilling to LazyAddPaymentMethod.
  • Modified getAccount API call to use a template string.
  • Enhanced TeamPlanBadge to support new billing plans.
  • Updated modal components for consistency.
  • Improved PricingCard to utilize new billing plan logic.
  • Introduced getStripeCheckoutLink for better payment handling.
  • Refactored billing pages to handle team-specific logic.
  • Enhanced user experience in the onboarding process.

The following files were skipped due to too many changes: apps/dashboard/src/components/settings/Account/Billing/Pricing.tsx, apps/dashboard/src/components/settings/Account/Billing/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ❌ Failed (Inspect) Nov 16, 2024 2:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 16, 2024 2:24am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 16, 2024 2:24am
wallet-ui ⬜️ Skipped (Inspect) Nov 16, 2024 2:24am

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 911470e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:24 Inactive
Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 15, 2024
Copy link
Member Author

jnsdls commented Nov 15, 2024

@jnsdls jnsdls marked this pull request as ready for review November 15, 2024 08:25
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 15, 2024 — with Graphite App
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (a00233d) to head (911470e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5432   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files        1070     1070           
  Lines       55690    55690           
  Branches     4033     4033           
=======================================
  Hits        25356    25356           
  Misses      29647    29647           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a258674
packages 40.63% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.88 KB (0%) 898 ms (0%) 262 ms (+163.55% 🔺) 1.2 s
thirdweb (cjs) 105.07 KB (0%) 2.2 s (0%) 348 ms (+76.17% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 72 ms (+1192.77% 🔺) 186 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (+1629.42% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 67 ms (+358.09% 🔺) 442 ms

@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 56050bc to c35f6c9 Compare November 15, 2024 08:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:56 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from c35f6c9 to 8bae24b Compare November 15, 2024 08:57
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:57 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 8bae24b to 30f5cfc Compare November 15, 2024 09:01
@gregfromstl gregfromstl marked this pull request as draft November 15, 2024 23:05
@jnsdls jnsdls marked this pull request as ready for review November 15, 2024 23:16
Base automatically changed from 11-14-update_dependencies to main November 15, 2024 23:16
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from f9306cf to a258674 Compare November 15, 2024 23:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 23:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 23:24 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 8359304 to 72f4a6c Compare November 15, 2024 23:50
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:50 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 72f4a6c to 8392e77 Compare November 16, 2024 00:38
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 16, 2024 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 16, 2024 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 16, 2024 00:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants