Enable implicit default logger only in testing with -v #2877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes
-v
and-test.v=true
handling only takes effect iftesting.Testing() = true
, i.e.go test
.Why is it important?
The current implementation always treats
-v
and-test.v=true
specially, even outside ofgo test
, and outputs verbose logs that are not easy to suppress. This makes it difficult to use testcontainers outside ofgo test
.Related issues
How to test this PR
These behaviors should not be changed.
These behavior will be changed to suppress default logging.