Remove password from ConnectionInfo
#697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
requested review from
sjmiller609,
nhudson,
ianstanton and
ChuckHend
as code owners
sjmiller609
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
This looks right to me, but I think it may break on deserialization on the control plane end, so you have to carefully coordinate right correct order of merges for this one.
Good to go when you believe it's the right order of merging, i.e. issues handled control plane side, and you also make sure app and readonly users' passwords not getting sent to control plane either
| @@ -59,7 +59,6 @@ pub struct ConnectionInfo { | |||
| pub pooler_host: Option<String>, | |||
| pub port: u16, | |||
| pub user: String, | |||
| pub password: String, | |||
| pub app_user: String, | |||
| pub app_password: String, | |||
There was a problem hiding this comment.
what about app password?
There was a problem hiding this comment.
I thought there is also readonly user, but I'm not sure where that info is
| @@ -303,7 +303,6 @@ pub async fn get_pg_conn( | |||
| pooler_host, | |||
| port: 5432, | |||
| user: postgres_user, | |||
| password: postgres_pw, | |||
| app_user, | |||
| app_password: app_pw, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.