fixup! QUIC APL: Make use of QUIC_OBJ infrastructure

t8m · Nov 12, 2024 · 60aadde · 60aadde
1 parent 71aa094
commit 60aadde
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ssl/quic/quic_impl.c b/ssl/quic/quic_impl.c
@@ -575,7 +575,7 @@ SSL *ossl_quic_new(SSL_CTX *ctx)
 #endif
 
     /* Create the handshake layer. */
-    qc->tls = ossl_ssl_connection_new_int(ctx, TLS_method());
+    qc->tls = ossl_ssl_connection_new_int(ctx, &qc->ssl, TLS_method());
     if (qc->tls == NULL || (sc = SSL_CONNECTION_FROM_SSL(qc->tls)) == NULL) {
         QUIC_RAISE_NON_NORMAL_ERROR(NULL, ERR_R_INTERNAL_ERROR, NULL);
         goto err;

diff --git a/ssl/quic/quic_port.c b/ssl/quic/quic_port.c
@@ -363,6 +363,11 @@ static SSL *port_new_handshake_layer(QUIC_PORT *port)
     SSL *tls = NULL;
     SSL_CONNECTION *tls_conn = NULL;
 
+    /*
+     * TODO(QUIC SERVER): NULL below needs to be replaced with a real user SSL
+     * object of either the listener or the domain which is associated with
+     * the port. https://github.com/openssl/project/issues/918
+     */
     tls = ossl_ssl_connection_new_int(port->channel_ctx, NULL, TLS_method());
     if (tls == NULL || (tls_conn = SSL_CONNECTION_FROM_SSL(tls)) == NULL)
         return NULL;