Add support for load-pass-plugin option
#1472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @artemcm, @lhames, @DougGregor. |
artemcm
reviewed
Oct 23, 2023
| @@ -435,6 +435,10 @@ extension Driver { | |||
| commandLine.appendFlag(.pluginPath) | |||
| commandLine.appendPath(pluginPathRoot.localPluginPath) | |||
| } | |||
|
|
|||
| if let passPluginPath = parsedOptions.getLastArgument(.loadPassPluginEQ) { | |||
There was a problem hiding this comment.
Could you please also guard this with:
isFrontendArgSupported(.loadPassPluginEQ)
|
Please add a simple test that the flag is propagated to the expected |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
d41ec65
to
916a707
Compare
|
Rebased to main, and added a test forwarding the options to the frontend, thanks! |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
916a707
to
3128d28
Compare
|
Rebased to main, solved conflicts. |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
3128d28
to
b6bb0f2
Compare
|
Ping @artemcm Is this ready to land? The test in swiftlang/swift#68985 (comment) was passing! |
artemcm
approved these changes
Oct 8, 2024
Looks like this needs to resolve a merge conflict first. |
`Options.swift` has been regenerated so as to include `load-pass-plugin` option as well.
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
b6bb0f2
to
1e84ca9
Compare
|
@swift-ci test |
|
Seems like CI skipped theses builds. @artemcm Can we try that again please? |
|
@swift-ci test |
|
Gentle ping for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options.swifthas been regenerated so as to includeload-pass-pluginoption as well.Frontend implementation at swiftlang/swift#68985.