Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scudo sanitizer runtime name #1424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented Aug 21, 2023

The Scudo sanitizer runtime name was changed from scudo-<arch>.{a,so} to scudo_standalone-<arch>.{a,so} in https://reviews.llvm.org/D138157.

@artemcm; I'm not sure how to deal with the fact that the driver may need to span across multiple toolchain versions here as there won't be a consistent runtime name that works for older and newer toolchains.

-- this is likely targeting the wrong branch, but I don't see a branch corresponding to rebranch on the driver.

This is part of the work for rebranch; rdar://114209408

The Scudo sanitizer runtime name was changed from scudo-<arch>.{a,so} to
scudo_standalone-<arch>.{a,so} in https://reviews.llvm.org/D138157.
@etcwilde etcwilde requested a review from artemcm August 21, 2023 21:51
@artemcm
Copy link
Contributor

artemcm commented Sep 7, 2023

the fact that the driver may need to span across multiple toolchain versions here as there won't be a consistent runtime name

Perhaps this is something we could capture in the output of -print-target-info so that the compiler informs the driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants