Error handling to afterSaveLilypondPDF Method #4288
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirePheonix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4257 - Add Error Handling to afterSaveLilypondPDF Method
@walterbender This PR adds functionality and UI for error handling in the afterSaveLilypondPDF method. The error-handling logic is currently kept inside commented-out code to ensure it does not interfere with the existing functionality. This will serve as a foundation for future development.
Steps to Reproduce the Error:
To simulate and observe the error-handling UI:
Note: Server response errors take some time to invoke, so please watch the entire video till the end to see the error box appear.
Music.Blocks.-.Google.Chrome.2025-01-18.05-46-02.1.mp4
Proposal
If required, I can include and then comment out the debugging code in this PR to assist future development efforts. Let me know if you'd like me to proceed with this adjustment.
Additional details.
SOME MORE INFO ON WHAT ACTUALLY CAUSES THE ERROR???
After debugging for some time, I realized that the error is being invoked from the server side itself, rather than being a problem in the data being sent. Here's the debugging video.
404024146-2dec8672-f1db-4c5b-9eaf-847e343c6218.mp4
Here's the code responsible for server connectivity:
