Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking feat: adopt styled-components v6 #419

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

quantizor
Copy link
Collaborator

@quantizor quantizor commented May 8, 2024

This PR relies on styled-components/styled-components#4307 (currently published under the test tag) released

To test this:

yarn add @xstyled/styled-components@beta styled-components@^6.1.11

TODO:

  • resolve typing error when using <x.*> (something about invalid children)

@quantizor quantizor requested a review from gregberge May 8, 2024 00:42
@quantizor quantizor force-pushed the styled-components-v6 branch 4 times, most recently from c5ee24e to 7e02de1 Compare May 8, 2024 18:43
@quantizor quantizor force-pushed the styled-components-v6 branch 4 times, most recently from 3286dd9 to 86d9a88 Compare May 9, 2024 18:07
@quantizor
Copy link
Collaborator Author

quantizor commented May 9, 2024

Alright I'm annoyed by lerna, I cannot for the life of me figure out how to only do a major bump for @xstyled/styled-components. No matter how I organize the commits it always bumps all of the packages even though I changed the versioning strategy to independent 😠

Edit: Manually bumping the version and yarn lerna publish from-package --conventional-commits did it

BREAKING CHANGE: The minimum version of styled-components is now v6.1.11. See the
[migration guide](https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v6) for more information.
@quantizor quantizor merged commit d3b4696 into main May 9, 2024
1 check passed
@quantizor quantizor deleted the styled-components-v6 branch May 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant