Upgrade to compose 1.7 #9894

jaynewstrom-stripe · 2025-01-13T15:00:53Z

Summary

I found a workaround for our upgrade issue here: https://issuetracker.google.com/issues/372512084#comment2

emerge-tools · 2025-01-13T15:05:02Z

3 builds increased size

Name	Version	Download	Change	Install	Change	Approval
⚠️ Stripe Identity Example com.stripe.android.identity.example.theme1	21.3.1-theme1 (20)	3.9 MB	⬆️ 105.6 kB (2.78%)	9.2 MB	⬆️ 227.8 kB (2.55%)	N/A
⚠️ Financial Connections Example com.stripe.android.financialconnections.example	21.3.1 (210301)	5.6 MB	⬆️ 124.4 kB (2.28%)	11.0 MB	⬆️ 256.2 kB (2.39%)	N/A
PaymentSheet Example com.stripe.android.paymentsheet.example	21.3.1 (11)	8.4 MB	⬆️ 5.0 kB (0.06%)	15.9 MB	⬆️ 12.7 kB (0.08%)	N/A

Stripe Identity Example 21.3.1-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 227.8 kB (2.55%)
Total download size change: ⬆️ 105.6 kB (2.78%)

Largest size changes

Item	Install Size Change	Download Size Change
_COROUTINE._BOUNDARY	⬆️ 39.6 kB	⬆️ 19.0 kB
androidx.camera.core.impl.utils.executor.MainThreadExecutor	⬇️ -30.3 kB	⬇️ -14.6 kB
📝 androidx.compose.ui.focus.FocusInteropUtils	⬆️ 29.1 kB	⬆️ 14.0 kB
androidx.compose.ui.input.key.KeyEvent_androidKt	⬇️ -28.6 kB	⬇️ -13.7 kB
🗑 androidx.compose.ui.Modifier$-CC	⬇️ -27.0 kB	⬇️ -13.0 kB

View Treemap

Financial Connections Example 21.3.1 (210301)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 256.2 kB (2.39%)
Total download size change: ⬆️ 124.4 kB (2.28%)

Largest size changes

Item	Install Size Change	Download Size Change
📝 androidx.compose.ui.unit.ConstraintsKt	⬆️ 103.0 kB	⬆️ 48.5 kB
📝 androidx.compose.ui.unit.AndroidDensity_androidKt	⬆️ 80.2 kB	⬆️ 37.8 kB
🗑 androidx.room.util.TableInfo$Column$Companion	⬇️ -78.5 kB	⬇️ -36.9 kB
📝 androidx.compose.ui.unit.DensityKt	⬆️ 78.1 kB	⬆️ 36.8 kB
🗑 kotlin.internal.ProgressionUtilKt	⬇️ -68.1 kB	⬇️ -32.0 kB

View Treemap

PaymentSheet Example 21.3.1 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 12.7 kB (0.08%)
Total download size change: ⬆️ 5.0 kB (0.06%)

Largest size changes

Item	Install Size Change	Download Size Change
org.bouncycastle.pqc.crypto.xmss.XMSSNodeUtil	⬇️ -18.9 kB	⬇️ -8.7 kB
com.stripe.android.paymentsheet.paymentdatacollection.ach.USBankA...	⬇️ -18.1 kB	⬇️ -8.3 kB
com.stripe.android.uicore.address.AutocompleteCapableAddressType$...	⬆️ 13.7 kB	⬆️ 6.2 kB
📝 androidx.constraintlayout.core.widgets.analyzer.DependencyNode$Ty...	⬆️ 12.9 kB	⬆️ 5.9 kB
🗑 androidx.constraintlayout.core.widgets.ConstraintAnchor$Type$Enum...	⬇️ -12.8 kB	⬇️ -5.9 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

github-actions · 2025-01-13T15:07:22Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼──────────┬──────────┬───────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff      
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
      dex │   3.9 MiB │   3.9 MiB │ +4.6 KiB │  8.6 MiB │  8.6 MiB │ +12.5 KiB 
     arsc │   2.3 MiB │   2.3 MiB │   -128 B │  2.3 MiB │  2.3 MiB │    -128 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │ 25.2 KiB │ 25.2 KiB │       0 B 
      res │ 908.4 KiB │ 908.4 KiB │      0 B │  1.4 MiB │  1.4 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │    +35 B │  1.6 MiB │  1.6 MiB │     +35 B 
    other │   1.4 MiB │   1.4 MiB │    -39 B │  1.6 MiB │  1.6 MiB │       0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
    total │  12.6 MiB │  12.6 MiB │ +4.5 KiB │ 21.5 MiB │ 21.5 MiB │ +12.4 KiB 

 DEX     │ old   │ new   │ diff               
─────────┼───────┼───────┼────────────────────
   files │     1 │     1 │    0               
 strings │ 40693 │ 40751 │  +58 (+151 -93)    
   types │ 14036 │ 14064 │  +28 (+80 -52)     
 classes │ 11708 │ 11734 │  +26 (+47 -21)     
 methods │ 59700 │ 59814 │ +114 (+6182 -6068) 
  fields │ 39877 │ 39990 │ +113 (+4585 -4472) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6209 │ 6207 │ -2 (+0 -2)

APK

     compressed      │     uncompressed      │                                           
──────────┬──────────┼───────────┬───────────┤                                           
 size     │ diff     │ size      │ diff      │ path                                      
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  3.9 MiB │ +4.6 KiB │   8.6 MiB │ +12.5 KiB │ ∆ classes.dex                             
  2.3 MiB │   -128 B │   2.3 MiB │    -128 B │ ∆ resources.arsc                          
 50.2 KiB │    -32 B │ 118.6 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                    
  7.8 KiB │    +25 B │   7.7 KiB │     +25 B │ ∆ assets/dexopt/baseline.prof             
  1,017 B │    +10 B │     885 B │     +10 B │ ∆ assets/dexopt/baseline.profm            
 53.5 KiB │     -4 B │ 118.7 KiB │       0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │     -2 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                       
    271 B │     -1 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  6.3 MiB │ +4.5 KiB │  11.1 MiB │ +12.4 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   40693 │ 40751 │ +58 (+151 -93) 
  
  +  DefaultValue: null
  +  instead of 
  + " for destination 
  + ([^/]*?|)
  + , animationSpec: 
  + , animationSpecDuration: 
  + , durationNanos: 
  + , fadeOutSpec=
  + , initialVelocity: 
  + , isComplete: 
  + , new instance: 
  + , placementSpec=
  + , rippleAlpha=
  + , start: 
  + , value: 
  + . Following required arguments are missing: 
  + . Missing required arguments [
  + An instance of SeekableTransitionState has been used in different Transitions. Previous instance: 
  + Anchored drag finished
  + Cannot navigate to startDestination 
  + Cannot set route "
  + Cannot transition entry that is not in the back stack
  + Expecting fraction between 0 and 1. Got 
  + LB/o0;
  + LC/K0;
  + LC/L0;
  + LC/M0;
  + LC/N0;
  + LC/O0;
  + LC/P0;
  + LC/Q0;
  + LC/R0;
  + LC/S0;
  + LC/T0;
  + LC/U0;
  + LC/V0;
  + LC/W0;
  + LC5/M;
  + LD/H0;
  + LFFFFFLII
  + LFFLLLI
  + LG/n;
  + LILZL
  + LJ/g0;
  + LJ/h0;
  + LJ/i0;
  + LJJJLII
  + LJJLII
  + LL0/C1;
  + LLLLZLII
  + LN9/h0;
  + LN9/i0;
  + LN9/j0;
  + LN9/k0;
  + LR/X;
  + LY/A;
  + LY/B;
  + LY/C;
  + LY/D;
  + LY/E;
  + LY0/J;
  + Landroidx/activity/C;
  + Landroidx/compose/material/DraggableAnchorsElement;
  + Landroidx/compose/material/a;
  + LazyLayoutAnimateItemElement(fadeInSpec=
  + Lc/i;
  + Lc/j;
  + Lc/k;
  + Lc/l;
  + Lc2/M;
  + Lc2/N;
  + Ld2/w;
  + Ld2/x;
  + Ld2/y;
  + Lm8/f0;
  + Lp1/p;
  + Ls0/X;
  + Navigation destination that matches route 
  + ReceiveChannel.consumeAsFlow can be collected just once
  + RippleConfiguration(color=
  + VLFLLLZLL
  + VLLFL
  + VLLLIZLLL
  + VLLLLFL
  + VLLLLLLLLLII
  + VLLLLLLLLLLLII
  + VLLLLLLLLLLLLII
  + VLLLLLLLLZZZLLLLLII
  + VLLLLLLLLZZZLLLLLLII
  + VLLLLLLZFLI
  + VLLLLLLZFLLI
  + VLLLLLLZFLLLII
  + VLLLLLLZFLLLLII
  + VLLLLZZLLLLLLZLZL
  + VLLLZZLLZLLLLLLLIII
  + VLLLZZLLZLLLLLLLLII
  + VLLZZLLZLLLLLLLLIII
  + VLLZZLLZLLLLLLLLLII
  + VLZFLL
  + VLZLIL
  + VLZLJLJJFLL
  + VLZZLLLFFI
  + VLZZLLZLLLLLLI
  + VZFJ
  + VZILLLLLLI
  + VZZLLLFFLI
  + You cannot set a new graph on a NavController with entries on the back stack after the NavController has been destroyed. Please ensure that your NavHost has the same lifetime as your NavController.
  + You must collect the progress flow
  + [LB/N;
  + [LC/V0;
  + [LC5/m;
  + [LD/l0;
  + [LI0/Q;
  + [LJ/B;
  + [LJ/T;
  + [LJ/e0;
  + [LN9/W;
  + [LN9/X;
  + [LN9/j0;
  + [LS/F1;
  + [LS/Q0;
  + [LS/g1;
  + [LS/x3;
  + [LY0/C;
  + [LY0/w;
  + [LY0/y;
  + [LZ0/C;
  + [LZ7/B1;
  + [LZ7/Z;
  + [LZ7/v1;
  + [Lc2/L;
  + [Lc2/t;
  + [Lj0/r;
  + [Ljava/lang/Boolean;
  + [Ljava/lang/Long;
  + [Lk6/l;
  + [Lm6/g;
  + [Lm8/f0;
  + [Lo/N;
  + [Lo/d1;
  + [Lo1/c;
  + deepLink
  + inputParams
  + layoutlib
  + onBack cancelled
  + progress nanos: 
  + snapTo() was canceled because state was changed to 
  + targetState while waiting for composition
  + try {
                    …tring()
                  }
  + uriPattern
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"c971a3b","r8-mode":"full","version":"8.7.14"}
  
  - ) was not set. Did you use ModalBottomSheetState with the ModalBottomSheetLayout composable?
  - , fadeOutSpec=null)
  - FFFL
  - LFFFFFLI
  - LFLI
  - LI0/d0;
  - LJJJLI
  - LLLLZLI
  - LM5/E;
  - LS/E3;
  - LS/F3;
  - LZ0/K;
  - LZ7/Q1;
  - LazyLayoutAnimateItemElement(fadeInSpec=null, placementSpec=
  - Lc0/c;
  - Lc0/d;
  - Lc0/e;
  - Lj0/A;
  - Lj0/B;
  - Lj0/C;
  - Lj0/D;
  - Lj0/E;
  - Lk6/v;
  - Ll0/u;
  - Lm6/i;
  - Lm6/j;
  - Lo/o1;
  - Lo1/k;
  - Lz9/f;
  - Navigation destination that matches request 
  - SnapshotStateMap(value=
  - The density on ModalBottomSheetState (
  - VILIILI
  - VJIJF
  - VLFLZLLLL
  - VLLFI
  - VLLLIZLLLI
  - VLLLLIIZLIJLL
  - VLLLLLLLLLLLI
  - VLLLLLLLLZZZLLLLIII
  - VLLLLLLLLZZZLLLLLIII
  - VLLLLLZFLLLII
  - VLLLLLZFLLLLII
  - VLLLLZZLLLLLZLZL
  - VLLLZZLLZLLLLLLIII
  - VLLLZZLLZLLLLLLLII
  - VLLZZLLZLLLLLLLIII
  - VLLZZLLZLLLLLLLLII
  - VLZJLJJFLLL
  - VLZZLLLFFII
  - VLZZLLZLLLLL
  - VLZZZZ
  - VZFLL
  - VZILLLLLLII
  - VZLLJJFLJLL
  - VZZLLLFFLII
  - [LB/M;
  - [LC/I0;
  - [LC5/l;
  - [LD/k0;
  - [LI0/S;
  - [LJ/P;
  - [LJ/b0;
  - [LJ/y;
  - [LN9/T;
  - [LN9/U;
  - [LN9/d0;
  - [LS/E1;
  - [LS/M0;
  - [LS/c1;
  - [LS/z3;
  - [LY0/B;
  - [LY0/v;
  - [LY0/x;
  - [LZ0/D;
  - [LZ7/C1;
  - [LZ7/a0;
  - [LZ7/y1;
  - [Lc2/J;
  - [Lc2/u;
  - [Lj0/u;
  - [Lk6/m;

...✂

ARSC

ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6209 │ 6207 │ -2 (+0 -2) 
  - style/FloatingDialogTheme
  - style/FloatingDialogWindowTheme

jaynewstrom-stripe · 2025-01-13T20:37:35Z

...stripe.android.common.ui_ElementsBottomSheetLayoutScreenshotTest_testExpanded[DarkTheme].png

This is bad! Need to figure out how to fix!

jaynewstrom-stripe · 2025-01-13T20:37:43Z

...tripe.android.common.ui_ElementsBottomSheetLayoutScreenshotTest_testExpanded[LightTheme].png

jaynewstrom-stripe · 2025-01-13T20:39:01Z

...ndroid.link.ui.inline_LinkInlineSignupScreenshotTest_testExpanded[DarkTheme,DefaultFont].png

Cursors went missing in these screenshots, but still exist in production!

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch 3 times, most recently from bdba073 to 70eb92a Compare January 13, 2025 16:21

jaynewstrom-stripe added 2 commits January 13, 2025 11:53

Update to compose 1.7.4.

6059034

Update dependency baseline.

cb8c8b4

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch from 4fe9ae2 to 3a35e9d Compare January 13, 2025 18:53

Update screenshots.

21d56e7

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch 2 times, most recently from 77361ee to bd8f43c Compare January 13, 2025 20:01

jaynewstrom-stripe commented Jan 13, 2025

View reviewed changes

jaynewstrom-stripe added 2 commits January 13, 2025 14:15

More updates.

669b73a

Extend timeout.

d427efa

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch from bd8f43c to d427efa Compare January 13, 2025 21:15

Comment out failing tests.

bbd2310

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to compose 1.7 #9894

Upgrade to compose 1.7 #9894

jaynewstrom-stripe commented Jan 13, 2025 •

edited

Loading

emerge-tools bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

jaynewstrom-stripe Jan 13, 2025

jaynewstrom-stripe Jan 13, 2025

jaynewstrom-stripe Jan 13, 2025

Upgrade to compose 1.7 #9894

Are you sure you want to change the base?

Upgrade to compose 1.7 #9894

Conversation

jaynewstrom-stripe commented Jan 13, 2025 • edited Loading

Summary

emerge-tools bot commented Jan 13, 2025 • edited Loading

3 builds increased size

Stripe Identity Example 21.3.1-theme1 (20)com.stripe.android.identity.example.theme1

Financial Connections Example 21.3.1 (210301)com.stripe.android.financialconnections.example

PaymentSheet Example 21.3.1 (11)com.stripe.android.paymentsheet.example

github-actions bot commented Jan 13, 2025 • edited Loading

jaynewstrom-stripe Jan 13, 2025

Choose a reason for hiding this comment

jaynewstrom-stripe Jan 13, 2025

Choose a reason for hiding this comment

jaynewstrom-stripe Jan 13, 2025

Choose a reason for hiding this comment

jaynewstrom-stripe commented Jan 13, 2025 •

edited

Loading

emerge-tools bot commented Jan 13, 2025 •

edited

Loading

Stripe Identity Example 21.3.1-theme1 (20)
com.stripe.android.identity.example.theme1

Financial Connections Example 21.3.1 (210301)
com.stripe.android.financialconnections.example

PaymentSheet Example 21.3.1 (11)
com.stripe.android.paymentsheet.example

github-actions bot commented Jan 13, 2025 •

edited

Loading