fix: overflowing story content overlaps sidebar #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tlow92 thanks for the contribution 🙏 can you add an example to the example project which can show the problem/fix to make sure there is no regression |
feat: add example for Layout overflow behavior
|
I noticed theres actually a similar issue on mobile, pushed a similar change for that layout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If the content of a story overflows the container it might overlap with the sidebar, preventing interactions with it.
What I did
Set
overflow: hiddento the content container.For demonsteration purpose I changed the Button styles, but it's not part of the PR. @dannyhw Let me know if I should add an example story to demonstrate this.