Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update c implementation for math/base/special/cidentityf #4774

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

refactor: update c implementation for math/base/special/cidentityf #4774

wants to merge 8 commits into from
+716 −65

Conversation

DhruvArvindSingh
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • refactors C implementation for @stdlib/math/base/special/cidentityf along with relevant tests, benchmarks and examples to follow latest conventions
  • added test.native.js, benchmark.native.js, addon file , native.js
  • updated the readme file , package.json , benchmark.c , examples.c

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@DhruvArvindSingh
refactor: update c implementation for math/base/special/cidentityf
8b2a160 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cidentityf $\color{green}155/155$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}155/155$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@DhruvArvindSingh
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@DhruvArvindSingh
Copy link
Contributor Author

DhruvArvindSingh commented Jan 16, 2025 •
edited
Loading

good afternoon @gunjjoshi , please give this a review

kgryte
kgryte requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor comments, this PR should be close to merge.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 18, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhruvArvindSingh @stdlib-bot @kgryte