Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Folder structure for tests for app #497

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BassCoder2808
Copy link
Contributor

  • Created a folder tests
  • Segregates all the class tests into their respective files for easier test handling

@BassCoder2808
Copy link
Contributor Author

Hi @rtgdk can you please check this once and let me know if I am doing it correctly, like we need to do something similar for the api folder so, if this one looks good, I will follow the similar structure for it as well

Copy link
Collaborator

@rtgdk rtgdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the screenshot and the command used to run all test cases. Show the output as successfull


class ArchiveLicenseNamespaceViewsTestCase(StaticLiveServerTestCase):

def setUp(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a common setup and teardown function in test_utils.py and use it wherever we can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtgdk I had gone through most of the test files in api and apps like mostly for them each setup and teardown functions are different only, so I feel this would not be of much help

@BassCoder2808
Copy link
Contributor Author

Please provide the screenshot and the command used to run all test cases. Show the output as successfull

image
Hi @rtgdk I think all the tests are working like I tried this on both the main and Test-Files branch and the tests which are failing are common like they are the firefox ones I think it cannot find the relevant webdriver on my local wsl setup
So once I like do the same for the other modules can you please run my branch locally before merging it

@rtgdk
Copy link
Collaborator

rtgdk commented Oct 3, 2023

Overall changes LGTM. I hope there is no code leakage in this - very difficult to review for that. I would have loved to have a common setup/teardown for all tests and having all tests run without failure/skipping but I guess these will need some rethinking on how to run test cases run - currently a lot of duplicate code exists .

@BassCoder2808 Can you please list down the test cases not working on your machine? This will make the dataset for tests affected by selenium/firefox usecases and provide us a start to move these to unit based framework.

There are already some issues opened for fixing these testcases. Let's try to fix some of them.

Holding to merge this diff for sometime - until I run tests on this branch locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants