-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Folder structure for tests for app #497
base: main
Are you sure you want to change the base?
Conversation
Hi @rtgdk can you please check this once and let me know if I am doing it correctly, like we need to do something similar for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the screenshot and the command used to run all test cases. Show the output as successfull
|
||
class ArchiveLicenseNamespaceViewsTestCase(StaticLiveServerTestCase): | ||
|
||
def setUp(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a common setup and teardown function in test_utils.py
and use it wherever we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rtgdk I had gone through most of the test files in api
and apps
like mostly for them each setup
and teardown
functions are different only, so I feel this would not be of much help
|
Overall changes LGTM. I hope there is no code leakage in this - very difficult to review for that. I would have loved to have a common setup/teardown for all tests and having all tests run without failure/skipping but I guess these will need some rethinking on how to run test cases run - currently a lot of duplicate code exists . @BassCoder2808 Can you please list down the test cases not working on your machine? This will make the dataset for tests affected by selenium/firefox usecases and provide us a start to move these to unit based framework. There are already some issues opened for fixing these testcases. Let's try to fix some of them. Holding to merge this diff for sometime - until I run tests on this branch locally. |
tests