-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linters to the project #473
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,28 @@ | |||
[MESSAGES CONTROL] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's the change when these linters are applied to all the files in the project? I think I will delay merging this just to have less conflicts with other open PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had just made the files and ran them only on few files and not all. Should I run them on all the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, run all the test. We need to confirm everything works fine after your changes land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BassCoder2808 Did you run the tests for this after linting? Also make sure the app works fine and there are no code leakages.
• Install the necessary linters:
• Create configuration files for each linter:
options
options.
options.
• Integrate the linters into the project workflow:
in the pre-commit hook.
pre-commit hook.
the pre-commit hook.