Popover update #155
Popover update #155
Conversation
Make popover scrollable, displayed on click, and hidden on click anywhere else.
|
@ekongobie Good. i found one more issue in this - When the input box is selected (which is by default) and then we click on the popover button, it doesn't show the pop over. Only when clicked again, the pop over appears. Can you look into it? [ TO test -> click on a popover, then click on the input box, then again on the same popover] Also, I just noticed that we have manually added the content in each popover. Changing this pop over would require extra efforts. Can you look into this and propose a new way to load this content? Let me know if you need more info/help regarding this. Also, I noticed that we manually |
|
@rtgdk I am looking into the "click" issue. The default trigger for the popovers is the "click" action, so I can remove that option completely. |
|
@rtgdk I have solved the popover click issue. However, inorder to solve this, the dismissal of the popover is only done when we click "outside", that is, not on the popover icon. Please test for convenience. I also removed the help text from the javascript and put is in a python file; and then I passed the help text to javascript through form field attributes. |
There was a problem hiding this comment.
@ekongobie Changes look good. Python looks less cluttered than js code, thanks for that! Left some comments before I merge.
| @@ -593,6 +590,7 @@ | |||
| }); | |||
| } | |||
| </script> | |||
| <script type="text/javascript" src="{% static 'js/editor/codemirror.js' %}"></script> | |||
There was a problem hiding this comment.
Why do we need this script?
|
@ekongobie If you could resolve the merge conflicts, I'll go ahead and merge this PR. |
Fixes #151
Make popover scrollable, displayed on click, and hidden on click anywhere else.