Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MemorySafeLinkedBlockingQueue #1213

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alipay.sofa.rpc.common.threadpool;

import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;

/**
* Can completely solve the OOM problem caused by {@link java.util.concurrent.LinkedBlockingQueue},
* does not depend on {@link java.lang.instrument.Instrumentation}
*
* @see <a href="https://github.com/apache/incubator-shenyu/blob/master/shenyu-common/src/main/java/org/apache/shenyu/common/concurrent/MemorySafeLinkedBlockingQueue.java">MemorySafeLinkedBlockingQueue</a>
*/
public class MemoryLimitCalculator {

private static volatile long maxAvailable;

private static final ScheduledExecutorService SCHEDULER = Executors.newSingleThreadScheduledExecutor();

static {
// immediately refresh when this class is loaded to prevent maxAvailable from being 0
refresh();
// check every 50 ms to improve performance
SCHEDULER.scheduleWithFixedDelay(MemoryLimitCalculator::refresh, 50, 50, TimeUnit.MILLISECONDS);
Runtime.getRuntime().addShutdownHook(new Thread(SCHEDULER::shutdown));
}

private static void refresh() {
maxAvailable = Runtime.getRuntime().freeMemory();
}

/**
* Get the maximum available memory of the current JVM.
*
* @return maximum available memory
*/
public static long maxAvailable() {
return maxAvailable;
}

/**
* Take the current JVM's maximum available memory
* as a percentage of the result as the limit.
*
* @param percentage percentage
* @return available memory
*/
public static long calculate(final float percentage) {
if (percentage <= 0 || percentage > 1) {
throw new IllegalArgumentException();
}
return (long) (maxAvailable() * percentage);
}

/**
* By default, it takes 80% of the maximum available memory of the current JVM.
*
* @return available memory
*/
public static long defaultLimit() {
return (long) (maxAvailable() * 0.8);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alipay.sofa.rpc.common.threadpool;

import java.util.Collection;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;

/**
* Can completely solve the OOM problem caused by {@link java.util.concurrent.LinkedBlockingQueue},
* does not depend on {@link java.lang.instrument.Instrumentation}
*
* @see <a href="https://github.com/apache/incubator-shenyu/blob/master/shenyu-common/src/main/java/org/apache/shenyu/common/concurrent/MemorySafeLinkedBlockingQueue.java">MemorySafeLinkedBlockingQueue</a>
*/
public class MemorySafeLinkedBlockingQueue<E> extends LinkedBlockingQueue<E> {

private static final long serialVersionUID = 8032578371739960142L;

public static int THE_256_MB = 256 * 1024 * 1024;

private int maxFreeMemory;

public MemorySafeLinkedBlockingQueue() {
this(THE_256_MB);
}

public MemorySafeLinkedBlockingQueue(final int maxFreeMemory) {
super(Integer.MAX_VALUE);
this.maxFreeMemory = maxFreeMemory;
}

public MemorySafeLinkedBlockingQueue(final Collection<? extends E> c,
final int maxFreeMemory) {
super(c);
this.maxFreeMemory = maxFreeMemory;
}

/**
* set the max free memory.
*
* @param maxFreeMemory the max free memory
*/
public void setMaxFreeMemory(final int maxFreeMemory) {
this.maxFreeMemory = maxFreeMemory;
}

/**
* get the max free memory.
*
* @return the max free memory limit
*/
public int getMaxFreeMemory() {
return maxFreeMemory;
}

/**
* determine if there is any remaining free memory.
*
* @return true if has free memory
*/
public boolean hasRemainedMemory() {
return MemoryLimitCalculator.maxAvailable() > maxFreeMemory;
}

@Override
public void put(final E e) throws InterruptedException {
if (hasRemainedMemory()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to notify users when they fail to put an element to the queue.

Copy link

@loongs-zhang loongs-zhang Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Maybe notify action should like java.util.concurrent.RejectedExecutionHandler.

super.put(e);
}
}

@Override
public boolean offer(final E e, final long timeout, final TimeUnit unit) throws InterruptedException {
return hasRemainedMemory() && super.offer(e, timeout, unit);
}

@Override
public boolean offer(final E e) {
return hasRemainedMemory() && super.offer(e);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
package com.alipay.sofa.rpc.common.utils;

import com.alipay.sofa.rpc.common.threadpool.MemorySafeLinkedBlockingQueue;

import java.util.concurrent.BlockingQueue;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.PriorityBlockingQueue;
Expand Down Expand Up @@ -248,7 +250,7 @@ public static BlockingQueue<Runnable> buildQueue(int size, boolean isPriority) {
queue = size < 0 ? new PriorityBlockingQueue<Runnable>()
: new PriorityBlockingQueue<Runnable>(size);
} else {
queue = size < 0 ? new LinkedBlockingQueue<Runnable>()
queue = size < 0 ? new MemorySafeLinkedBlockingQueue<Runnable>()
: new LinkedBlockingQueue<Runnable>(size);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall be an ArrayBlockingQueue once size is set. LinkedBlockingQueue will not block/reject adding a new element when reaching threshold(input size).

But it's Ok not to fix this, as it is what it was.

}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alipay.sofa.rpc.common.threadpool;

import net.bytebuddy.agent.ByteBuddyAgent;
import org.junit.Assert;
import org.junit.Test;

import java.lang.instrument.Instrumentation;

public class MemorySafeLinkedBlockingQueueTest {

@Test
public void test() throws Exception {
ByteBuddyAgent.install();
final Instrumentation instrumentation = ByteBuddyAgent.getInstrumentation();
final long objectSize = instrumentation.getObjectSize((Runnable) () -> {
});
int maxFreeMemory = (int) MemoryLimitCalculator.maxAvailable();
MemorySafeLinkedBlockingQueue<Runnable> queue = new MemorySafeLinkedBlockingQueue<>(maxFreeMemory);

// all memory is reserved for JVM, so it will fail here
Assert.assertEquals(queue.offer(() -> {
}), false);

// maxFreeMemory-objectSize Byte memory is reserved for the JVM, so this will succeed
queue.setMaxFreeMemory((int) (MemoryLimitCalculator.maxAvailable() - objectSize));
Assert.assertEquals(queue.offer(() -> {
}), true);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.alipay.sofa.rpc.common.utils;

import com.alipay.sofa.rpc.common.struct.NamedThreadFactory;
import com.alipay.sofa.rpc.common.threadpool.MemorySafeLinkedBlockingQueue;
import org.junit.Assert;
import org.junit.Test;

Expand Down Expand Up @@ -151,7 +152,7 @@ public void buildQueue() throws Exception {
BlockingQueue<Runnable> queue = ThreadPoolUtils.buildQueue(0);
Assert.assertEquals(queue.getClass(), SynchronousQueue.class);
queue = ThreadPoolUtils.buildQueue(-1);
Assert.assertEquals(queue.getClass(), LinkedBlockingQueue.class);
Assert.assertEquals(queue.getClass(), MemorySafeLinkedBlockingQueue.class);
queue = ThreadPoolUtils.buildQueue(10);
Assert.assertEquals(queue.getClass(), LinkedBlockingQueue.class);
}
Expand All @@ -165,7 +166,7 @@ public void buildQueue1() throws Exception {
queue = ThreadPoolUtils.buildQueue(100, true);
Assert.assertEquals(queue.getClass(), PriorityBlockingQueue.class);
queue = ThreadPoolUtils.buildQueue(-1, false);
Assert.assertEquals(queue.getClass(), LinkedBlockingQueue.class);
Assert.assertEquals(queue.getClass(), MemorySafeLinkedBlockingQueue.class);
queue = ThreadPoolUtils.buildQueue(100, false);
Assert.assertEquals(queue.getClass(), LinkedBlockingQueue.class);
}
Expand Down