Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect app vulnerabilities in container scans #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pjrharley
Copy link

I have found that my container scan correctly prints out that there is a critical vulnerability, but then the build happily passes:


Tested 4 projects, 1 contained vulnerable paths.
...
no vulnerabilities of at least 'critical' severity were detected, not failing build

Running the scan locally I could see the output doesn't put the vulnerabilities at the top level of the JSON output
and so they are totally ignored. This change means that we look through all the application vulnerabilities also if they exist.

@pjrharley pjrharley requested a review from a team as a code owner March 6, 2024 12:01
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants