feat: add "/rest" to snyk api url automatically #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
change looks good, but can we craft a better commit message, since this will make it into the release details:
|
paulrosca-snyk
force-pushed
the
feat/snyk-env-var-default
branch
from
5efa710
to
f9dbcd5
Compare
paulrosca-snyk
force-pushed
the
feat/snyk-env-var-default
branch
from
f9dbcd5
to
b0cda75
Compare
paulrosca-snyk
force-pushed
the
feat/snyk-env-var-default
branch
from
b0cda75
to
848dd27
Compare
BREAKING CHANGE: The SNYK_API environment variable should be set to the same value as intended for the Snyk CLI and no longer requires the "/rest" suffix. Instead, only the base URL of the Snyk API shall be used. To adapt to the new version, change the SNYK_API environment variable to omit the "/rest", e.g. `SNYK_API="https://api.snyk.io"`.
paulrosca-snyk
force-pushed
the
feat/snyk-env-var-default
branch
from
848dd27
to
3fffbb4
Compare
mcombuechen
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
parlayexpects users to provide the Snyk API URL with the/restsuffix.This change ensures that the snyk clients add this suffix automatically.