OpenXR: Separate graphics handling from main OpenXR code #243
Conversation
Signed-off-by: Daniel Adams <[email protected]>
Signed-off-by: Daniel Adams <[email protected]>
| pub enum GraphicsProvider {} | ||
|
|
||
| pub trait GraphicsProviderMethods<G: Graphics> { | ||
| fn enable_graphics_extensions(exts: &mut ExtensionSet); |
There was a problem hiding this comment.
Do you think it is better if you use associated type, for example:
type GraphicsType: Graphics;
fn create_session(
device: &SurfmanDevice,
instance: &Instance,
system: SystemId,
) -> Result<(Session<Self::GraphicsType>, FrameWaiter, FrameStream<Self::GraphicsType>), Error>;
There was a problem hiding this comment.
I believe the PR code is strictly equivalent, and I don't have a good sense for whether we should prefer one style over the other when there's no behaviour difference like this case.
| pub enum GraphicsProvider {} | ||
|
|
||
| pub trait GraphicsProviderMethods<G: Graphics> { | ||
| fn enable_graphics_extensions(exts: &mut ExtensionSet); |
There was a problem hiding this comment.
I believe the PR code is strictly equivalent, and I don't have a good sense for whether we should prefer one style over the other when there's no behaviour difference like this case.
That's fair yeah, I'll adjust that today. |
Signed-off-by: Daniel Adams <[email protected]>
This removes the explicit dependency on D3D11 in the OpenXR code and should hopefully lay the groundwork for future support on other platforms like Linux or Android.