Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 entry ts refactor #1141

Merged
merged 22 commits into from
Jan 17, 2025
Merged

V14 entry ts refactor #1141

merged 22 commits into from
Jan 17, 2025

Conversation

DanDroryAu
Copy link
Contributor

Change entry and config into .ts files.

Add type declarations for webpack globals.

@DanDroryAu DanDroryAu requested a review from a team as a code owner December 23, 2024 04:58
Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: bcbea02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few random thoughts

fixtures/translations/.gitignore Show resolved Hide resolved
packages/sku/src/context/configSchema.ts Outdated Show resolved Hide resolved
packages/sku/src/context/defaultSkuConfig.ts Outdated Show resolved Hide resolved
packages/sku/src/entry/client/index.tsx Outdated Show resolved Hide resolved
packages/sku/src/entry/server/server.ts Show resolved Hide resolved
packages/sku/src/entry/makeExtractor.tsx Outdated Show resolved Hide resolved
packages/sku/src/entry/client/index.tsx Outdated Show resolved Hide resolved
packages/sku/src/types/global.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though CI is now failing.

@DanDroryAu
Copy link
Contributor Author

LGTM, though CI is now failing.

This is because of the global.d.ts importing the type SkuCSP. I've moved that back since its not being used in the csp.js file. The other type moved.

@DanDroryAu DanDroryAu merged commit f221937 into v14-mjs-refactor Jan 17, 2025
4 checks passed
@DanDroryAu DanDroryAu deleted the v14-entry-ts-refactor branch January 17, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants