Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dateInputV2 #4434

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: dateInputV2 #4434

wants to merge 7 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Nov 7, 2024

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

  • New component <DateInputV2 /> which doesn't use React Date Picker
  • <Button /> : New props onMouseEnter and onMouseLeave

@lisalupi lisalupi requested review from mhervouet and a team November 7, 2024 15:02
@lisalupi lisalupi self-assigned this Nov 7, 2024
@lisalupi lisalupi requested review from BABAK0T0, alexandre-combemorel and a team and removed request for a team, BABAK0T0 and alexandre-combemorel November 7, 2024 15:02
@lisalupi lisalupi requested review from JulienSaguez and removed request for a team November 7, 2024 15:02
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: f721b30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/helpers.ts Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarMonthly.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarMonthly.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/DateInputV2/CalendarDaily.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 91.77331% with 45 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1b91d6b). Learn more about missing BASE report.
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/DateInput/index.tsx 59.72% 29 Missing ⚠️
.../src/components/DateInput/__tests__/index.test.tsx 92.10% 9 Missing ⚠️
packages/ui/src/components/DateInput/Context.tsx 20.00% 4 Missing ⚠️
...s/ui/src/components/DateInput/components/Popup.tsx 94.23% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4434   +/-   ##
=======================================
  Coverage        ?   86.99%           
=======================================
  Files           ?      332           
  Lines           ?    12320           
  Branches        ?     3434           
=======================================
  Hits            ?    10718           
  Misses          ?     1602           
  Partials        ?        0           
Files with missing lines Coverage Δ
.../src/components/DateField/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/form/src/components/DateField/index.tsx 82.85% <ø> (ø)
packages/ui/src/components/Button/index.tsx 97.39% <ø> (ø)
.../src/components/DateInput/__tests__/helper.test.ts 100.00% <100.00%> (ø)
.../components/DateInput/components/CalendarDaily.tsx 100.00% <100.00%> (ø)
...omponents/DateInput/components/CalendarMonthly.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/DateInput/constants.ts 100.00% <100.00%> (ø)
packages/ui/src/components/DateInput/helpers.ts 100.00% <100.00%> (ø)
...kages/ui/src/components/DateInput/helpersLocale.ts 100.00% <100.00%> (ø)
...s/ui/src/components/DateInput/components/Popup.tsx 94.23% <94.23%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b91d6b...f721b30. Read the comment docs.

@matthprost matthprost self-requested a review November 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants