Handle non-StandardError in custom functions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent segmentation fault due to returning null pointer when non-StandardError exception is raised in custom functions. Abort with error message instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #244
When exception that is not a subclass of
StandardErrorhappens inside custom sass function, it's not handled bySassC::FunctionsHandlerand gets raised up toFFI::Functionblock body, where ffi gem silently catches it and treats as if block returnednil. This causes segmentation fault later in C code, when trying to dereference null pointer.This changes
rescueinfunctions_handlerto handle all exceptions.Recovering from non-
StandardErrormight be not a good idea in general (for example when exception isNoMemoryError), but I didn't find proper ways to abort the whole process inside ffi callback. TriedKernel#abort, it just prints error message and causes callback to return nil so the same segfault remains. Maybe usingabort()libc function directly is an option but I doubt if it's portable enough between systems. So, I think, rescuing all exceptions is okay here.