-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set the deployment target when building std #133092
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
fd382a0
to
dd8ca01
Compare
Okay... So this didn't actually work initially, since bootstrap is for some I've rebased and fixed that in the first and second commits, but it may break more than I think, so this should probably get a try build before merging. |
Commands that end up invoking cc-rs, i.e. Cargo (through build scripts) and cmake-rs don't need the CFLAGS from cc-rs itself, as they will just end up as duplicates.
dd8ca01
to
9ae3190
Compare
This didn't actually activate properly, since cmake-rs calls cc-rs internally, and as such the flag was set anyhow.
50812ff
to
2294b05
Compare
2294b05
to
f816d33
Compare
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies cc @jieyouxu |
Not sure if I should? It changes in theory (we pass different flags), but in practice it shouldn't (because those flags were already set by |
cc
has a bug/feature (I guess depending on how you look at it) where the default deployment target is taken from the SDK instead of fromrustc
. This causescompiler-builtins
to buildcompiler-rt
with the wrong deployment target on iOS.I've been meaning to change how
cc
works in this regard, but that's a lengthy process, so let's fix it in bootstrap for now.The behaviour be seen locally with
./x build library --set build.optimized-compiler-builtins=true
for various target triples, and then inspecting withotool -l build/host/stage1/lib/rustlib/*/lib/libcompiler_builtins-*.rlib | rg 'minos|version'
. I have added a rmake test that ensures that we now have the same version everywhere.Fixes #128419
Fixes rust-lang/compiler-builtins#650
See also rust-lang/cargo#13115
@rustbot label O-apple